Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple address search #116

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Allow multiple address search #116

merged 4 commits into from
Oct 24, 2024

Conversation

tingxuanp
Copy link

@tingxuanp tingxuanp commented Oct 21, 2024 •
edited
Loading

Closes #117

@tingxuanp tingxuanp added this to the v1.4 milestone Oct 21, 2024
DanzaSeah
DanzaSeah approved these changes Oct 22, 2024
View reviewed changes
Copy link

@DanzaSeah DanzaSeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment about abstracting the messages for exceptions

src/main/java/seedu/address/logic/parser/FindCommandParser.java Outdated
for (String address : argMultimap.getAllValues(PREFIX_ADDRESS)) {
String addressInput = address.trim();
if (addressInput.isEmpty()) {
throw new ParseException("Address cannot be empty!");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to abstract out the exception message

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thanks for pointing out, will make the change

HanB1n
HanB1n reviewed Oct 23, 2024
View reviewed changes
Copy link

@HanB1n HanB1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (ø) 14.00 <0.00> (+1.00)
...rdspredicate/AddressContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 6.00 <1.00> (ø)
...wordspredicate/EmailContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...wordspredicate/PhoneContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...eywordspredicate/TagContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)

... and 9 files with indirect coverage changes

@DanzaSeah DanzaSeah merged commit 5966e95 into AY2425S1-CS2103T-F15-4:master Oct 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanB1n HanB1n HanB1n left review comments

@DanzaSeah DanzaSeah DanzaSeah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Allow multiple address search
3 participants
@tingxuanp @HanB1n @DanzaSeah