-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update User Guide #170
Update User Guide #170
Conversation
Update Help Message to WedLinker's user guide. Update AB3 and AddressBook to reflect WedLinker. Update Jar File link. Update Ui example image. Update Quick Start guide to fit the target audience. Fix hyperlinks to accurately reflect its target.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits and also a concern about the name of the json file we save the data in
@@ -6,7 +6,8 @@ | |||
|
|||
# WedLinker User Guide | |||
|
|||
WedLinker is a **desktop app for managing contacts, optimized for use via a Line Interface** (CLI) while still having the benefits of a Graphical User Interface (GUI). If you can type fast, AB3 can get your contact management tasks done faster than traditional GUI apps. | |||
WedLinker is a **desktop app for managing contacts, optimized for use via a Line Interface** (CLI) while still having the benefits of a Graphical User Interface (GUI). </br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I remember prof saying something like the benefits of GUI being a bit vague, maybe we should expand on this?
|
||
1. Download the latest `.jar` file from [here](https://github.com/se-edu/addressbook-level3/releases). | ||
2. Download the latest version of WedLinker from [here](https://github.com/AY2425S1-CS2103T-F15-4/tp/releases/). Select `WedLinker.jar` to begin the download. | ||
![release.png](images/release.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you added an image of the release page so that the user knows if it's right.
|
||
1. Open a command terminal, `cd` into the folder you put the jar file in, and use the `java -jar addressbook.jar` command to run the application.<br> | ||
4. Open WedLinker by double clicking the program file, `WedLinker.jar`.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can also have alternative opening instructions for cd
ing into the file, I think sometimes if JAR does not work then user needs to use cd
method - can have a troubleshooting section ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the recommended way even for everyday users to double-click? I'm not too sure about it, correct me if I'm wrong!
@@ -58,37 +62,47 @@ WedLinker is a **desktop app for managing contacts, optimized for use via a Lin | |||
* Items with `…` after them can be used multiple times including zero times.<br> | |||
e.g. `[t/TAG]…` can be used as ` ` (i.e. 0 times), `t/friend`, `t/friend t/family` etc. | |||
|
|||
* Commands in WedLinker uses prefix to specify the parameters, the prefixes are stated as such: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe typo, "Commands in WedLinker use prefixes to..."
![help message](images/helpMessage.png) | ||
|
||
Format: `help` | ||
|
||
### Listing all Persons : `list` | ||
|
||
Shows a list of all saved [Persons](#adding-a-person-add) in the WedLinker. | ||
Shows a list of all saved [Persons](#person-features) in the WedLinker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you linked this to the Person features section
|
||
### Editing the data file | ||
|
||
AddressBook data are saved automatically as a JSON file `[JAR file location]/data/addressbook.json`. Advanced users are welcome to update data directly by editing that data file. | ||
WedLinker data are saved automatically as a JSON file `[JAR file location]/data/WedLinker.json`. Advanced users are welcome to update data directly by editing that data file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Is this true? Did we change it to be saved as WedLinker.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is still addressbook.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments on parts from previous UG changes
@@ -287,7 +294,7 @@ Format: `delete-wedding w/WEDDINGNAME [f/]` | |||
* The no contacts should be assigned to the `Wedding` before it is deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed in previous review but should this line just say "No contacts should be ..."
@@ -233,7 +240,7 @@ Format: `delete-tag t/TAGNAME [f/]` | |||
* The `Tag` cannot be assigned to any contacts. | |||
* If the `Tag` is in used, you can use `f/` to force the deletion of the `Tag` and unassign this tag from all contacts. | |||
|
|||
### Wedding Features | |||
## Wedding Features | |||
|
|||
### Adding a Wedding : `create-wedding` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 252, maybe should be "... there should not be/there cannot be any duplicated Weddings."
|
||
### Tag Features | ||
## Tag Features | ||
|
||
### Adding a tag : `create-tag` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 216 below, maybe should be "Tag a specified contact based on their INDEX
with a Tag
" just to make sure it's clear what index is referring to
@@ -287,7 +294,7 @@ Format: `delete-wedding w/WEDDINGNAME [f/]` | |||
* The no contacts should be assigned to the `Wedding` before it is deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 273 above, maybe should have "Edits the specific Wedding
at the INDEX in the view that lists weddings", because 'list-weddings' view might be too close to the actual command and too technical? Not sure about this
@@ -6,7 +6,8 @@ | |||
|
|||
# WedLinker User Guide | |||
|
|||
WedLinker is a **desktop app for managing contacts, optimized for use via a Line Interface** (CLI) while still having the benefits of a Graphical User Interface (GUI). If you can type fast, AB3 can get your contact management tasks done faster than traditional GUI apps. | |||
WedLinker is a **desktop app for managing contacts, optimized for use via a Line Interface** (CLI) while still having the benefits of a Graphical User Interface (GUI). </br> | |||
If you can type fast, WedLinker can get your contact management tasks done faster than traditional GUI apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this can still be more user-centric and targeted towards wedding planners, right now it still seems a bit generic? Maybe can talk about how its designed specifically for wedding planners to efficiently plan weddings
![result for 'find n/alex david'](images/findCommandName.png) | ||
* `find t/friends` returns all Contacts tagged with Friends <br> | ||
![result for `find t/friends](images/findCommandTag.png) | ||
* `find w/Amy's Wedding` returns all Contacts involved with Amy's Wedding <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change this to Casey instead to match the image?
@@ -233,7 +240,7 @@ Format: `delete-tag t/TAGNAME [f/]` | |||
* The `Tag` cannot be assigned to any contacts. | |||
* If the `Tag` is in used, you can use `f/` to force the deletion of the `Tag` and unassign this tag from all contacts. | |||
|
|||
### Wedding Features | |||
## Wedding Features | |||
|
|||
### Adding a Wedding : `create-wedding` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for line 265 since I can't add a comment there - should we give an example of how the force tag is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 251 - maybe can change to "the weddingname should be alphanumeric" rather than "is alphanumeric"?
@@ -287,7 +294,7 @@ Format: `delete-wedding w/WEDDINGNAME [f/]` | |||
* The no contacts should be assigned to the `Wedding` before it is deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo/ grammar error here - "There should not be contacts assigned to.."/"There should be no"?
@@ -287,7 +294,7 @@ Format: `delete-wedding w/WEDDINGNAME [f/]` | |||
* The no contacts should be assigned to the `Wedding` before it is deleted. | |||
* If there are still contacts assigned, you can use `f/` to force the deletion of the `Wedding` and unassign all contacts. | |||
|
|||
### Task Features | |||
## Task Features | |||
|
|||
### Creating a Task : `create-task` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to specify the different task types and their respective commands/ keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
### Editing the data file | ||
|
||
AddressBook data are saved automatically as a JSON file `[JAR file location]/data/addressbook.json`. Advanced users are welcome to update data directly by editing that data file. | ||
WedLinker data are saved automatically as a JSON file `[JAR file location]/data/WedLinker.json`. Advanced users are welcome to update data directly by editing that data file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is still addressbook.json
@@ -15,17 +16,21 @@ WedLinker is a **desktop app for managing contacts, optimized for use via a Lin | |||
|
|||
## Quick start | |||
|
|||
1. Ensure you have Java `17` or above installed in your Computer. | |||
1. Ensure you have `Java 17` or above installed in your Computer. If you do not have Java 17 installed, or you are unsure, refer to the guide below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember Dr. Wee asking "How can users know whether they have Java 17?" -- Maybe can add instruction to "Open terminal and run java -version
, or something similar?
|
||
1. Open a command terminal, `cd` into the folder you put the jar file in, and use the `java -jar addressbook.jar` command to run the application.<br> | ||
4. Open WedLinker by double clicking the program file, `WedLinker.jar`.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the recommended way even for everyday users to double-click? I'm not too sure about it, correct me if I'm wrong!
Update Help Message to WedLinker's user guide.
Update AB3 and AddressBook to reflect WedLinker.
Update Jar File link.
Update Ui example image.
Update Quick Start guide to fit the target audience. Fix hyperlinks to accurately reflect its target.