forked from nus-cs2103-AY2425S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UG (Task commands) #203
Merged
HanB1n
merged 4 commits into
AY2425S1-CS2103T-F15-4:master
from
DanzaSeah:Branch-UpdateUG
Oct 31, 2024
Merged
Update UG (Task commands) #203
HanB1n
merged 4 commits into
AY2425S1-CS2103T-F15-4:master
from
DanzaSeah:Branch-UpdateUG
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2425S1-CS2103T-F15-4/tp: Fix dependencies in UI UML Fix SampleDataUtil task format Add Vendor, Todo, Event, Deadline, Description, TaskName, Date Fix wrong hastag return value Update UML Class Diagram for Storage Class Update to match remote Add TagSequenceDiagram and remove redundant code Update UML Class Diagram for Storage Class Add Find Command UML diagram Edit Find Command class diagram Update UI UML diagram Add Find Command class diagram Add Task Removed duplicate line Wedding --> WeddingAddress Update Tag, Person, Wedding UML diagram Revert "Fix add command prompt"
* 'master' of https://github.com/AY2425S1-CS2103T-F15-4/tp: Add more tests and create vendor packages Remove redundant code Fix checkstyle Remove logging statements Add vendor testcases Add AddressBook parser testcases Resolve merge conflicts and test cases Add logging and fix checkstyle Fix checkstyle and add assertions Add testcases and fix storage Change Assign Vendor Command formatting Add Unassign Vendor Command Add Vendor class, add and assign commands
* 'master' of https://github.com/AY2425S1-CS2103T-F15-4/tp: Update command summary in UG Standardise assign keywords Add parser test for edit wedding Add vendor command keyword tests Fix keyword test comments Add tests for command keywords Add command keywords Change tests to match case insensitivity Fix name case sensitivity Update User Guide Add titles for panes Fix checkstyle Fix minimum width Fix horizontal panel growth Fix entity list height growth Fix split view to fill Split view between person and others
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
tingxuanp
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
HanB1n
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Maybe can add some contextualised examples for how it is used!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.