Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Untag feature #64

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Add support for Untag feature #64

merged 12 commits into from
Oct 10, 2024

Conversation

DanzaSeah
Copy link

@DanzaSeah DanzaSeah commented Oct 6, 2024 •
edited
Loading

Add support for the untag feature, which allows users to untag one or more existing tags from a contact

Created UntagCommand class, UntagCommandParser class and respective test classes

@DanzaSeah DanzaSeah added this to the v1.2 milestone Oct 6, 2024
@DanzaSeah
Copy link
Author

fixes #61

@codecov Codecov
Copy link

codecov bot commented Oct 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ava/seedu/address/logic/commands/UntagCommand.java 82.85% 2 Missing and 4 partials ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 89.47% <ø> (ø) 4.00 <0.00> (ø)
...seedu/address/logic/parser/UntagCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/java/seedu/address/model/AddressBook.java 81.81% <100.00%> (ø) 16.00 <1.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 93.93% <100.00%> (+0.09%) 30.00 <1.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 84.00% <0.00%> (-3.50%) 14.00 <0.00> (ø)
...ava/seedu/address/logic/commands/UntagCommand.java 82.85% <82.85%> (ø) 9.00 <9.00> (?)

@DanzaSeah DanzaSeah self-assigned this Oct 6, 2024
@DanzaSeah DanzaSeah linked an issue Oct 6, 2024 that may be closed by this pull request
Create Untag feature #61
Closed
@DanzaSeah DanzaSeah changed the title Add support for Untag command Add support for Untag command Oct 8, 2024
@DanzaSeah DanzaSeah changed the title Add support for Untag command Add support for Untag feature Oct 8, 2024
@DanzaSeah DanzaSeah added the priority.High Must do label Oct 8, 2024
HanB1n
HanB1n reviewed Oct 9, 2024
View reviewed changes
Copy link

@HanB1n HanB1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Left a comment regarding consistency.

src/main/java/seedu/address/logic/commands/UntagCommand.java Outdated Show resolved Hide resolved
dasha3412
dasha3412 reviewed Oct 9, 2024
View reviewed changes
Copy link

@dasha3412 dasha3412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well structured and well done, no bugs found.

@DanzaSeah
Apply parsing by prefix logic
b74316a
@DanzaSeah
Merge branch 'master' of https://github.com/AY2425S1-CS2103T-F15-4/tp
a9ca31e 
* 'master' of https://github.com/AY2425S1-CS2103T-F15-4/tp: (50 commits)
  Fix formatting
  Change list of tags to type HashSet
  Abstract command messages to Messages class
  Fix formatting errors for phone
  Edit command usage message
  Reapply "Revert parsing logic to using prefix tag"
  Fix more formatting
  Fix formatting errors
  Update method name in test case
  Change method name
  Add FilterCommandParserTest, adapt FilterCommand and TagContainsKeywordsPredicate JavaDocs for Tag
  Separate JavaDoc for Filter/Find by name/tag
  Fix check style issues in test class
  Fix test cases
  Fix check style issues in test class
  Add more test for Tagging feature.
  Add JUnit tests for TagNameTest and UniqueTagListTest
  Add JUnit tests for TagTest
  Add JUnit tests for Messages and ModelManagerTest
  Add test for tag command in AddressbookParserTest
  ...
@DanzaSeah
Merge branch 'master' into branch-Untag
6c7837e 
# Conflicts:
#	src/main/java/seedu/address/logic/parser/AddressBookParser.java
@HanB1n HanB1n merged commit 14b54fe into AY2425S1-CS2103T-F15-4:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanB1n HanB1n HanB1n left review comments

@dasha3412 dasha3412 dasha3412 left review comments

Assignees

@DanzaSeah DanzaSeah

Labels
priority.High Must do
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Create Untag feature
3 participants
@DanzaSeah @HanB1n @dasha3412