Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make email optional #76

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Make email optional #76

merged 3 commits into from
Oct 10, 2024

Conversation

dasha3412
Copy link

Fixes #53

@dasha3412 dasha3412 added this to the v1.2 milestone Oct 9, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 92.59% <100.00%> (ø) 11.00 <0.00> (ø)
...rc/main/java/seedu/address/model/person/Email.java 92.85% <ø> (ø) 6.00 <0.00> (ø)

tingxuanp
tingxuanp reviewed Oct 9, 2024
View reviewed changes
Copy link

@tingxuanp tingxuanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except minor nits

src/test/java/seedu/address/logic/parser/AddCommandParserTest.java Show resolved Hide resolved
src/test/java/seedu/address/model/person/EmailTest.java Outdated Show resolved Hide resolved
riccoljy
riccoljy approved these changes Oct 9, 2024
View reviewed changes
Copy link

@riccoljy riccoljy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have similar nits as @tingxuanp (some repeated from #74), but LGTM

src/main/java/seedu/address/logic/parser/EditCommandParser.java Show resolved Hide resolved
src/test/java/seedu/address/logic/parser/AddCommandParserTest.java Show resolved Hide resolved
src/test/java/seedu/address/model/person/EmailTest.java Outdated Show resolved Hide resolved
@riccoljy riccoljy merged commit a11220b into AY2425S1-CS2103T-F15-4:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tingxuanp tingxuanp tingxuanp left review comments

@riccoljy riccoljy riccoljy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Make email optional in the add command.
3 participants
@dasha3412 @riccoljy @tingxuanp