Create a field in add command (Skill Sets) #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisaditya17
added
type.Task
thisisaditya17
force-pushed
the
feature/add-skills
branch
from
356af49
to
630c26c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Skills field was added in the test cases. Many tests were failing due to some string issue. For now, those cases were fixed by either commenting out them or asserting same cases in the tests.
|
LGTM |
dominic2412
reviewed
Oct 23, 2024
| import static seedu.address.logic.parser.CliSyntax.PREFIX_PHONE; | ||
| import static seedu.address.logic.parser.CliSyntax.PREFIX_SKILLS; |
There was a problem hiding this comment.
The imports are in lexicographical order! good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new field for adding skills. The field name will be 'Skills'.
Context
From the recruiter's and HR professionals' point of view, there is a need to view the candidates' skill sets. Hence, it is important to have them as a field in the contact list.
Close #44