Add view command #114
Add view command #114
Conversation
…ewing with view command
| tierLabel.getStyleClass().add(tier + "-tier"); | ||
|
|
||
| // Add the label to the FlowPane | ||
| assignedTier.getChildren().add(tierLabel); |
There was a problem hiding this comment.
Good idea. the issue now is that for those with no tier, there is now an awkward gap where Tier originally was.
There was a problem hiding this comment.
To add on, I think you can use a conditional to render and add the label only if the tier != "NA"
| */ | ||
| private void ensureSelectedPersonIsValid(ListChangeListener.Change<? extends Person> change) { | ||
| while (change.next()) { | ||
| if (selectedPerson.getValue() == null) { |
There was a problem hiding this comment.
perhaps you can use getSelectedPerson method here to improve maintainability.
| private void handleViewCommand(String commandText) { | ||
| if (!splitPane.getItems().contains(personDetailsPanelPlaceholder)) { | ||
| splitPane.getItems().add(personDetailsPanelPlaceholder); | ||
| placeholderImage.setVisible(false); | ||
| splitPane.setDividerPositions(0.6); | ||
| } | ||
|
|
||
| String[] commandParts = commandText.split("\\s+"); | ||
| if (commandParts.length > 1) { | ||
| try { | ||
| int index = Integer.parseInt(commandParts[1]) - 1; // Assuming 1-based indexing in UI | ||
| Person personToView = logic.getFilteredPersonList().get(index); | ||
| personDetailPanel.setPersonDetails(personToView); | ||
| } catch (NumberFormatException | IndexOutOfBoundsException e) { | ||
| // Handle invalid index | ||
| resultDisplay.setFeedbackToUser("Invalid person index."); | ||
| } | ||
| } else { | ||
| resultDisplay.setFeedbackToUser("Please provide a person index to view."); | ||
| } |
| tierLabel.getStyleClass().add(tier + "-tier"); | ||
|
|
||
| // Add the label to the FlowPane | ||
| assignedTier.getChildren().add(tierLabel); |
There was a problem hiding this comment.
To add on, I think you can use a conditional to render and add the label only if the tier != "NA"
| if (person != null && !filteredPersons.contains(person)) { | ||
| throw new PersonNotFoundException(); | ||
| } |
There was a problem hiding this comment.
| if (person != null && !filteredPersons.contains(person)) { | |
| throw new PersonNotFoundException(); | |
| } | |
| requireNonNull(person); | |
| if (!filteredPersons.contains(person)) { | |
| throw new PersonNotFoundException(); | |
| } |
Could consider doing this to match what the module did, but I have no issues with the current implementation either.
There was a problem hiding this comment.
Thanks for pointing out!
| resultDisplay.setFeedbackToUser(commandResult.getFeedbackToUser()); | ||
|
|
||
| if (commandText.trim().toLowerCase().startsWith("view")) { |
There was a problem hiding this comment.
Might be worth refactoring the predicate condition to a isViewCommand() method, similar to the isShowHelp() method.
Co-authored-by: leyew <[email protected]>
Co-authored-by: leyew <[email protected]>
iamdiluxedbutcooler
merged commit 8ca6273
into
AY2425S1-CS2103T-T14-4:master
closes #104
This command allows users to see detailed information about a specific person in the address book using the following syntax:
view <INDEX>