Update PersonCardFields to use Icons #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field labels are displayed in bolded text. Users are unable to quickly identify fields at one glance. Let's use Icons to allow users to quickly identify fields. Using Icons is preferable over images as it allows for Icons to be used in other UI elements.
iamdiluxedbutcooler
approved these changes
Oct 22, 2024
| @@ -64,6 +64,10 @@ dependencies { | |||
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.7.0' | |||
| implementation group: 'com.fasterxml.jackson.datatype', name: 'jackson-datatype-jsr310', version: '2.7.4' | |||
|
|
|||
| implementation 'org.kordamp.ikonli:ikonli-core:12.3.0' | |||
| implementation group: 'org.kordamp.ikonli', name: 'ikonli-fontawesome5-pack', version: '12.3.1' | |||
| implementation 'org.kordamp.ikonli:ikonli-javafx:12.3.1' | |||
There was a problem hiding this comment.
Love the use of icon pack package!!
| address.setFields("fas-building", person.getAddress().value); | ||
| email.setFields("fas-envelope", person.getEmail().value); | ||
| job.setFields("fas-briefcase", person.getJob().value); | ||
| income.setFields("fas-dollar-sign", person.getIncome().toString()); |
There was a problem hiding this comment.
Consider standardizing icon variable names based on their semantic usage rather than the default names!
For example, instead of:
fas-envelope > emailIcon
fas-dollar-sign > incomeIcon
There was a problem hiding this comment.
@colinhia Could you open an issue for this? Seems like a useful change but not a priority!
There was a problem hiding this comment.
That does sound like a great idea! Will open an issue for this, thanks for the suggestion!
itsme-zeix
approved these changes
Oct 23, 2024
| address.setFields("fas-building", person.getAddress().value); | ||
| email.setFields("fas-envelope", person.getEmail().value); | ||
| job.setFields("fas-briefcase", person.getJob().value); | ||
| income.setFields("fas-dollar-sign", person.getIncome().toString()); |
There was a problem hiding this comment.
@colinhia Could you open an issue for this? Seems like a useful change but not a priority!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field labels are displayed in bolded text.
Users are unable to quickly identify fields at one glance.
Let's use Icons to allow users to quickly identify fields.
Using Icons is preferable over images as it allows for Icons to be used in other UI elements.
When pulling this commit, remember to reload the build.gradle file for the new Ikonli dependencies.
Closes #117