Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icon Variable Names based on Semantic Usage #126

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

colinhia
Copy link

Icon variable names use the default names from the Icon Pack.

Developers are unable to easily tell what icons are present from the default names.

Lets update the Icon Variable names to reflect the Semantic Usage.

Closes #125

Colin Hia added 2 commits October 23, 2024 17:48
Icon variable names use the default names from the Icon Pack.

Developers are unable to easily tell what icons are present from the
default names.

Lets update the Icon Variable names to reflect the Semantic Usage.
Copy link

@FionaQY FionaQY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@itsme-zeix itsme-zeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the prompt update!

@itsme-zeix itsme-zeix merged commit c621827 into AY2425S1-CS2103T-T14-4:master Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Icon Variable names based on Semantic Usage
3 participants