Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParserClasses diagram #129

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

itsme-zeix
Copy link

@itsme-zeix itsme-zeix commented Oct 23, 2024

Added FilterCommandParser Class as it had differing behaviour from other command parser class (XYZCommandClass), as FilterCommandParser class creates an additional Predicate objects, which is combined to form a CombinedPredicate object.

image

Closes #128.

@itsme-zeix itsme-zeix added the priority.High Must do label Oct 23, 2024
@itsme-zeix itsme-zeix added this to the v1.4 milestone Oct 23, 2024
@itsme-zeix itsme-zeix self-assigned this Oct 23, 2024
Copy link

@ZShunRen ZShunRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

Copy link

@FionaQY FionaQY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good job!

@colinhia colinhia merged commit 445c41b into AY2425S1-CS2103T-T14-4:master Oct 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ParserClasses class diagram in DG to reflect FilterParserClass behaviour
4 participants