Refactor AddressBook to AgentAssist #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinhia
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Wondering if the name of the logger should be updated to be perhaps AA
There was a problem hiding this comment.
Couple more comments in this file use the name ab3 as well, so if the change is made those comment would have to be updated too
| @@ -23,27 +23,27 @@ | |||
| public class ModelManager implements Model { | |||
| private static final Logger logger = LogsCenter.getLogger(ModelManager.class); | |||
|
|
|||
| private final AddressBook addressBook; | |||
| private final AgentAssist agentAssist; | |||
| private final UserPrefs userPrefs; | |||
| private final FilteredList<Person> filteredPersons; | |||
| private final SimpleObjectProperty<Person> selectedPerson = new SimpleObjectProperty<>(); | |||
|
|
|||
| /** | |||
| * Initializes a ModelManager with the given addressBook and userPrefs. | |||
There was a problem hiding this comment.
Agent Assist is still an address book, so the comment makes sense but wondering if maybe we should change "given addressbook" to "given agentAssist"? What do y'all think, but it would mean we have to comb through for other comment references
itsme-zeix
approved these changes
Oct 25, 2024
docs/diagrams/UndoRedoState5.puml
Outdated
Comment on lines
10
to
12
| class State1 as "<u>ab0:AgentAssist</u>" | ||
| class State2 as "<u>ab1:AgentAssist</u>" | ||
| class State3 as "<u>ab3:AgentAssist</u>" |
There was a problem hiding this comment.
Might want to refactor this part too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137