Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Undo command #147

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

FionaQY
Copy link

@FionaQY FionaQY commented Oct 27, 2024

Closes #146

@FionaQY FionaQY added this to the v1.5 milestone Oct 27, 2024
@FionaQY FionaQY self-assigned this Oct 27, 2024
@FionaQY FionaQY changed the title Implements Undo command Implement Undo command Oct 29, 2024
Copy link

@colinhia colinhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just caught a minor typo in safeHistory

/**
* Save the history of the AgentAssist.
*/
private void safeHistory() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a minor typo? saveHistory


@Override
public boolean hasPreviousCommand() {
return this.historyAgentAssist != null;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of abstraction! Liked how clean this is with just adding saveHistory into each command works.

Copy link

@itsme-zeix itsme-zeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just some small changes to be made.

src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
Comment on lines 8 to 10
/**
* Clears the address book.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated!

Copy link

@itsme-zeix itsme-zeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the changes!

@FionaQY FionaQY merged commit a020740 into AY2425S1-CS2103T-T14-4:master Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Undo Command
3 participants