Refactor command error messages #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user uses a command with multiple flags wrong, namely `add` and `edit`, the error message only displays an error for the first invalid flag. Now the error message is cumulative, allowing users to correct multiple wrong flag values with 1 error message.
ZShunRen
requested review from
iamdiluxedbutcooler,
FionaQY,
itsme-zeix and
colinhia
and removed request for
iamdiluxedbutcooler,
FionaQY and
itsme-zeix
FionaQY
approved these changes
Nov 1, 2024
|
|
||
| // multiple invalid values but with purely optional fields, only the first in order of logical parsing is | ||
| // captured |
iamdiluxedbutcooler
approved these changes
Nov 1, 2024
| * @param <T> The return type of the method supplied by this supplier. | ||
| */ | ||
| @FunctionalInterface | ||
| public interface ThrowingSupplier<T> { |
There was a problem hiding this comment.
Nice abstraction with ThrowingSupplier!
| exclude('**/META-INF/*.SF', '**/META-INF/*.DSA', '**/META-INF/*.RSA') | ||
| exclude('**/*.md') // Markdown files | ||
| exclude('**/*.txt') // Text files | ||
| // exclude('**/*.png', '**/*.jpg') // Images, if not required |
There was a problem hiding this comment.
don't forget to clean up this commented lines later!
| @@ -26,7 +26,6 @@ public void toModelType_typicalPersonsFile_success() throws Exception { | |||
| JsonSerializableAgentAssist.class).get(); | |||
| AgentAssist agentAssistFromFile = dataFromFile.toModelType(); | |||
| AgentAssist typicalPersonsAgentAssist = TypicalPersons.getTypicalAgentAssist(); | |||
| System.out.println("Agent Assist: " + agentAssistFromFile); | |||
There was a problem hiding this comment.
I didn't realise you left that in as a debugging comment, let me add that back!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message for
addcommand is not specific, and does not tell the user which of their flags are missing.In addition, the error messages for add command are too long, requiring the user to horizontally scroll to the right to read it in full.
This can reduce readability.
The proper command messages have been formatted to have more
The error message for
addcommand is also able to inform the user which flag is missing.Minor changes:.
Closes #161