Issue #92 Display comittee member information as per requirement #103
Conversation
|
@anandology please review, I may have interpreted the ticket wrongly. |
devilankur18
changed the title
| incharges = filter(lambda m: m.role.role == u'Incharges', c.committee_members) | ||
| return incharges | ||
|
|
||
|
|
There was a problem hiding this comment.
This is the only troubling part.
The committee slug will be different for different levels. The Role for Incharge could be different as well.
I think it is better to take it from a config setting or the first available committee. Lets have a function to get the committee name and role. That'll return first available committee and first role from that, unless a config setting is specified. Lets use WARD_MASTER_COMMITTEE and WARD_MASTER_COMMITTEE_ROLE with WARD substituted with appropriate level name.
Also, In python it is idiomatic to use list comprehensions instead of map/filter. The usual practice is:
incharges = [m for m in c.committee_members if m.role.role == 'Incharges']
9f84324 to
bdf2871
Compare
- Showing incharges for every children place, right away in the list. - All the comittees and their memebers with contact info shown right away in comittees page.
devilankur18
force-pushed
the
comittee_members
branch
from
bdf2871 to
6751d09
Compare
| com = self.get_primary_committee() | ||
|
|
||
| if com: | ||
| committee_role_slug = app.config.get("%s_MASTER_COMMITTEE_ROLE" % self.type.short_name.upper(), com.type.roles.pop().role) |
There was a problem hiding this comment.
com.types.roles.pop() looks a bit scary. com.types.roles[0] is safer I think.
Don't worry, I'll take care of that.
There was a problem hiding this comment.
@anandology I think I tried that, but its was throwing some errors, as it was not an array some custom form for list.
|
@devilankur18 I've added link a mockup in #92. Please have a look at it and let me know your comments there. |
No description provided.