Context builder methods #17
Conversation
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
| @@ -7,7 +7,7 @@ packages=["ragdaemon"] | |||
|
|
|||
| [project] | |||
| name = "ragdaemon" | |||
| version = "0.2.3" | |||
| version = "0.2.5" | |||
There was a problem hiding this comment.
Ensure the version update is intentional and follows semantic versioning correctly as it affects package deployment and dependency resolution.
| @@ -1 +1 @@ | |||
| __version__ = "0.2.3" | |||
| __version__ = "0.2.5" | |||
There was a problem hiding this comment.
It's good to see consistency in the version update across the package definition in pyproject.toml and the module's __init__.py. Make sure all references to the version number are updated to avoid inconsistencies.
| return duplicate | ||
|
|
||
| def __add__(self, other: ContextBuilder) -> ContextBuilder: | ||
| duplicate = self.copy() |
There was a problem hiding this comment.
Consider implementing merging of 'document' fields when combining two ContextBuilder instances if documents differ or need merging depending on context logic.
| @@ -1,3 +1,6 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| from copy import deepcopy | |||
There was a problem hiding this comment.
Imports should be organized and grouped according to PEP 8 standards. from __future__ import annotations should be the first import, followed by standard library imports, and then third-party imports such as pathlib and typing imports.
| comments | ||
| ) | ||
| return duplicate | ||
|
|
There was a problem hiding this comment.
Be cautious when splitting lines and accessing them by index, as this line assumes there is at least one line in the document. Ideally, there should be a check to ensure the document isn't empty to prevent index errors.
|
|
||
| context = daemon.get_context("") | ||
| context.add_ref("src/interface.py:3-5") | ||
|
|
There was a problem hiding this comment.
The line range set to [3-5] seems to overlap with subsequent tests modifying the same area. Ensure tests have independent conditions or reset the state appropriately to avoid interdependencies between tests.
|
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Overall, the pull request introduces coherent version updates and extends functionality in |
No description provided.