Support pyenv on Windows #94
Conversation
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
0c705e7
to
1d876bc
Compare
|
@ala-ableton my changes should squash cleanly. Let me know when I should squash. |
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
bd05e01
to
9a325a1
Compare
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
9a325a1
to
78189f0
Compare
There was a problem hiding this comment.
Please rebase/squash, then re-rebase and edit 43d3b35 to make sure that export PYENV_ROOT=... keeps on coming before export PATH=..., instead of having export PATH=... move around.
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
b5b1c96
to
8f2a143
Compare
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
2 times, most recently
from
732bd30
to
6381850
Compare
|
So I've rebased this PR, and also added Windows support for the newly-added integration tests, but they keep timing out after 1 hour. The first time, the build failed with a different error (not a timeout): I've no idea why this is happening. 😞 |
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
5 times, most recently
from
161f29f
to
8c50355
Compare
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
8c50355
to
240d754
Compare
|
Ok! This PR is finally ready for review, since our CI nodes now have the updated version of Pyenv needed for Windows support. |
|
@ala-ableton Please let me know when I should rebase. |
|
@nre-ableton Feel free to rebase whenever you want. |
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
5d4b875
to
9e11f26
Compare
Done. Feel free to review. 😊 Note that I pushed a dropme commit just to make sure that installing fresh (uncached) Python versions still works. |
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
906aa3b
to
d7eca53
Compare
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
d7eca53
to
4ba1913
Compare
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
4ba1913
to
03f3599
Compare
In future commits, we'll need to modify the commands used depending on the platform (and some other factors as well). Storing them in a list will make this easier to manipulate.
This will facilitate Windows support, which will be added in a future commit.
This is needed to support pyenv on Windows.
This will be needed to fully support Windows, which will happen in a future commit.
This is needed to support pyenv on Windows, which will be added in a future commit.
This will be needed to support pyenv on Windows, which will happen in a subsequent commit.
To support Windows (which will be done in a subsequent commit), we'll need to translate Windows-style paths to Cygwin-style paths (for example, C:\foo\bar -> /c/foo/bar). The fileExists step only supports Windows-style paths when run on Windows, which means that we need to actually run pyenv to assert that it exists.
nre-ableton
force-pushed
the
nre/master/2497-pyenv-windows
branch
from
5837771
to
aa99293
Compare
|
Forgive the rebase/force-push, I just noticed a vim-related typo in a commit message and decided to just drop the experiment commits regarding |
This PR adds support for Windows in
pyenv.createVirtualEnv()andvirtualenv.create(). I've bumped the minor version since this is technically a breaking change, since these functions previously resulted in an error being thrown when run on Windows.