Skip to content

Commit

Permalink
TODOs cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
Buckram123 committed Aug 13, 2024
1 parent c809f23 commit 5b3576b
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion framework/packages/abstract-std/src/adapter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pub type InstantiateMsg<ModuleMsg = Empty> =

/// Trait indicates that the type is used as an app message
/// in the [`ExecuteMsg`] enum.
/// It's just a marker trait
/// Enables [`Into<ExecuteMsg>`] for BOOT fn-generation support.
pub trait AdapterExecuteMsg: Serialize {}
impl<T: AdapterExecuteMsg> From<T> for ExecuteMsg<T> {
fn from(request: T) -> Self {
Expand Down
3 changes: 0 additions & 3 deletions framework/packages/abstract-std/src/app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ use cosmwasm_std::{Addr, Empty};
use cw_controllers::AdminResponse;
use serde::Serialize;

// TODO: Current implementation don't work with CustomMessages
// Because if we do some `impl From<T> for X where T: SomeTrait`, we don't allow to implement ANY `From<T> for Y` outside of this crate

/// Trait indicates that the type is used as an app message
/// in the [`ExecuteMsg`] enum.
/// Enables [`Into<ExecuteMsg>`] for BOOT fn-generation support.
Expand Down
1 change: 0 additions & 1 deletion modules/contracts/apps/etf/src/handlers/receive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ use crate::{
state::{State, STATE},
};

// TODO: Custom handler
/// handler function invoked when the vault dapp contract receives
/// a transaction. In this case it is triggered when either a LP tokens received
/// by the contract or when the deposit asset is a cw20 asset.
Expand Down
1 change: 0 additions & 1 deletion modules/contracts/apps/payment/src/handlers/receive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use cw_asset::Asset;

use crate::contract::{AppResult, PaymentApp};

// TODO: custom execute msg
pub fn receive_handler(
deps: DepsMut,
env: Env,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use crate::{
msg::DepositHookMsg,
};

// TODO: custom execute msg
pub fn receive_cw20(
deps: DepsMut,
env: Env,
Expand Down

0 comments on commit 5b3576b

Please sign in to comment.