-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Adapter Access Control Logic #458
Update Adapter Access Control Logic #458
Conversation
Deploying abstract-docs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Noticed one edge case, which I hope is unlikely to happen
Yes, I think this is the behavior we want. A nucance here is that we want to do the admin-flag assertion on the direct admin of the app (i.e. the account that the app is installed on) vs the top-level account. Because an admin action on a sub-account should not require an admin flag be set on the owner account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update packages/abstract-std/src/objects/ownership/README.md
with an explanation of how the CALLING_TO_AS_ADMIN
value is used?
This PR aims at updating the Access Control for actions via the account.
Proposed changes:
ConfigureModule
message on the account for sending admin calls to modulesThis is Options 2 here, there is a mermaid diagram at the end to understand the situation a little better https://www.notion.so/abstract-money/Merging-Abstract-Account-Implementation-6d366bb35b3242adb6ae5787fb759cc8?pvs=4
Checklist