-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Interchain API for tests / execution #474
Better Interchain API for tests / execution #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the meaning of build
here?
…-review-interchain-abstract-testing-setup-for-interchain-v2
Waiting with this until we fix the unused tag |
…ract-testing-setup-for-interchain-v2
…ract-testing-setup-for-interchain-v2
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
modules/contracts/apps/ping-pong/tests/better_interchain_api.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering what better_interchain_api
is used for. Maybe it needs a better name or maybe we can update ping_pong_tests
to use the better API instead?
…-review-interchain-abstract-testing-setup-for-interchain-v2
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
…-review-interchain-abstract-testing-setup-for-interchain-v2
This PR aims at making the Abstract IBC dev experience even better in tests / actual executions.
This is Abstract cw1 because cw2 tests don't pass and I need tests
Proposed changes:
AbstractInterchainClient
that is responsible for deploying Abstract to all chains of anInterchainEnv
and linking them via an IBC connectionDepends on AbstractSDK/polytone#9
Checklist