Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Interchain API for tests / execution #474

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Sep 23, 2024

This PR aims at making the Abstract IBC dev experience even better in tests / actual executions.
This is Abstract cw1 because cw2 tests don't pass and I need tests
Proposed changes:

  • AbstractInterchainClient that is responsible for deploying Abstract to all chains of an InterchainEnv and linking them via an IBC connection

Depends on AbstractSDK/polytone#9

Checklist

  • CI is green.
  • Changelog updated.

@Kayanski Kayanski changed the base branch from main to develop/v2 September 23, 2024 11:49
@Kayanski Kayanski marked this pull request as ready for review September 23, 2024 11:49
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 61f4906
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of build here?

framework/packages/abstract-client/src/lib.rs Outdated Show resolved Hide resolved
framework/packages/abstract-client/src/lib.rs Outdated Show resolved Hide resolved
…-review-interchain-abstract-testing-setup-for-interchain-v2
@CyberHoward
Copy link
Contributor

Waiting with this until we fix the unused tag

@CyberHoward CyberHoward marked this pull request as draft September 30, 2024 08:31
@Kayanski Kayanski marked this pull request as ready for review October 8, 2024 12:53
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering what better_interchain_api is used for. Maybe it needs a better name or maybe we can update ping_pong_tests to use the better API instead?

…-review-interchain-abstract-testing-setup-for-interchain-v2
Buckram123 and others added 4 commits October 11, 2024 10:52
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
@Kayanski Kayanski merged commit 2692de9 into develop/v2 Oct 15, 2024
16 of 20 checks passed
@Kayanski Kayanski deleted the nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2 branch October 15, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants