Add abstract account to govdetails #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying abstract-docs with
|
| Latest commit: |
01e98e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://294df42e.abstract-docs.pages.dev |
| Branch Preview URL: | https://misha-abs-541-add-abstractac.abstract-docs.pages.dev |
CyberHoward
reviewed
Sep 27, 2024
| #[cfg(feature = "xion")] | ||
| { | ||
| if let Some(is_admin) = crate::state::AUTH_ADMIN.may_load(deps.storage)? { | ||
| // Clear auth if it was set |
There was a problem hiding this comment.
maybe this should be cleared in the post_tx hook?
There was a problem hiding this comment.
It's tough one! Clearing it here disallows more than 1 admin action per tx, but clearing it in post-tx can allow whitelisted module to execute as admin
There was a problem hiding this comment.
Actually clearing it in post tx will pretty much have same result as having check of if account caller is account address and no AUTH_ADMIN at all
CyberHoward
approved these changes
Sep 27, 2024
Buckram123
deleted the
misha/abs-541-add-abstractaccount-variant-to-govdetails
branch
Buckram123
added a commit
that referenced
this pull request
Sep 27, 2024
* init xion deployment script * formatting [skip ci] * update artifacts * add abstract package * lock * progress * guest/host error * Instantiated xion absacc * fix: abstract deployment * typo * update * formatting [skip ci] * fix account wasm selection * add query check on VC to ensure err on local deployments * remove default wasm build * remove redundant proto msg * update script * Add abstract account to govdetails (#476) * add abstract account to govdetails * Too big auth id * small cleanup * unused custom q * format * small doc comment on type * require xion for schema * comment out logic and checks --------- Co-authored-by: Buckram <[email protected]> Co-authored-by: Mykhailo Donchenko <[email protected]>
CyberHoward
added a commit
that referenced
this pull request
Sep 30, 2024
* add absacc * compiles * wip one auth per account * addauth * Move everything to account * account generic auth * feature flag * wasm compilable * use default type * update workspace hack * formatting [skip ci] * V2/xion deploy (#473) * init xion deployment script * formatting [skip ci] * update artifacts * add abstract package * lock * progress * guest/host error * Instantiated xion absacc * fix: abstract deployment * typo * update * formatting [skip ci] * fix account wasm selection * add query check on VC to ensure err on local deployments * remove default wasm build * remove redundant proto msg * update script * Add abstract account to govdetails (#476) * add abstract account to govdetails * Too big auth id * small cleanup * unused custom q * format * small doc comment on type * require xion for schema * comment out logic and checks --------- Co-authored-by: Buckram <[email protected]> Co-authored-by: Mykhailo Donchenko <[email protected]> * postmerge fixes * move xion script to interchain/scripts --------- Co-authored-by: cyberhoward <[email protected]> Co-authored-by: CyberHoward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AbstractAccount Governance and admin check based on first bit of signature id. This bit will set AUTH_ADMIN in state and used to verify admin call
#473 is base