Moved ica-client #482
Closed
Moved ica-client #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying abstract-docs with
|
| Latest commit: |
3405659
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd107f9a.abstract-docs.pages.dev |
| Branch Preview URL: | https://tests-ica-client.abstract-docs.pages.dev |
Buckram123
requested changes
Oct 7, 2024
Comment on lines
+88
to
+90
| // TODO: Should be a better way to have lookup table, maybe this will be nice: | ||
| // https://crates.io/crates/phf | ||
| let chains = map_macro::hash_map! { |
There was a problem hiding this comment.
Have you considered lookup table alternative? What do you think about phf?
There was a problem hiding this comment.
This is not possible because hf doesn't support keys of the type ARCHWAY[0] it seems here (see rust-phf/rust-phf#196)
CyberHoward
reviewed
Oct 7, 2024
| pub use polytone_evm::EVM_NOTE_ID; | ||
| pub use polytone_evm::POLYTONE_EVM_VERSION; | ||
|
|
||
| /// This needs no info. Owner of the contract is whoever signed the InstantiateMsg. |
There was a problem hiding this comment.
We can get rid of the addresses here and use the deterministic addresses.
Also would be nice to have an owner field here because it's easier to deploy that way if we want a different owner.
There was a problem hiding this comment.
base branch is main here, it's already removed in develop/v2
There was a problem hiding this comment.
yes, rebasing right now
|
Closed in favor of #486 (on version 2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at placing the ica-client definitions in their right place and creating tests for the implementation (EVM and Cosmos)
Checklist