-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccountTrace Serialization was done in the wrong order #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But it is state breaking, right? I'm surprised to not see a snapshot file changed here
Because we haven't used multi-hop accounts for now in the repo. |
framework/packages/abstract-std/src/objects/account/account_trace.rs
Outdated
Show resolved
Hide resolved
…SDK/abstract into fix/account-trace-serialization
framework/packages/abstract-std/src/objects/account/account_trace.rs
Outdated
Show resolved
Hide resolved
…SDK/abstract into fix/account-trace-serialization
d376891
to
84927ed
Compare
This Pr aims at correcting the display and parsing of account traces that was done in the wrong order.
It also changes the way accounts are serialized as keys.
Rationale:
The way Prefixer and KeyDeserialize was implemented is not compatible with cosmwasm-std 2, especially for composite keys. This implementation, didn't take into account the fact that the length of Vec used during serialization needs to be fixed for composite keys to be correctly usable for ranging.
In this Breaking PR, we fix this issue.
This PR is breaking on the account structure. Everything will break (see module migration testing for instance)
Checklist