Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't doubly-register native ibc contracts #559

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

adairrr
Copy link
Contributor

@adairrr adairrr commented Dec 13, 2024

Title. We were doubly-registering the IBC contracts that were registered by register_natives, resulting in the following error:

called `Result::unwrap()` on an `Err` value: status: Unknown, message: "failed to execute message; message index: 0: Module ibc-client provided by abstract with version 0.25.0 cannot be updated: execute wasm contract failed [CosmWasm/[email protected]/x/wasm/keeper/keeper.go:395] With gas wanted: '18446744073709551615' and gas used: '141224' ", details: [], metadata: MetadataMap { headers: {"date": "Fri, 13 Dec 2024 04:48:14 GMT", "content-type": "application/grpc", "content-length": "0", "strict-transport-security": "max-age=31536000; includeSubDomains"} }

Checklist

  • CI is green.
  • Changelog updated.

Title. We were doubly-registering the IBC contracts, resulting in the following error:

```
called `Result::unwrap()` on an `Err` value: status: Unknown, message: "failed to execute message; message index: 0: Module ibc-client provided by abstract with version 0.25.0 cannot be updated: execute wasm contract failed [CosmWasm/[email protected]/x/wasm/keeper/keeper.go:395] With gas wanted: '18446744073709551615' and gas used: '141224' ", details: [], metadata: MetadataMap { headers: {"date": "Fri, 13 Dec 2024 04:48:14 GMT", "content-type": "application/grpc", "content-length": "0", "strict-transport-security": "max-age=31536000; includeSubDomains"} }

```
Copy link

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d615463
Status: ✅  Deploy successful!
Preview URL: https://fe6355f4.abstract-docs.pages.dev
Branch Preview URL: https://adairrr-fix-double-ibc-regis.abstract-docs.pages.dev

View logs

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6%. Comparing base (bf989a9) to head (d615463).
Report is 75 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
...work/packages/abstract-interface/src/deployment.rs 86.3% <ø> (+5.5%) ⬆️

... and 88 files with indirect coverage changes

@Kayanski Kayanski merged commit 51e68e6 into main Dec 16, 2024
14 of 16 checks passed
@Kayanski Kayanski deleted the adairrr/fix-double-ibc-register branch December 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants