Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix challange app #96

Merged
merged 53 commits into from
Oct 19, 2023
Merged

Fix challange app #96

merged 53 commits into from
Oct 19, 2023

Conversation

CyberHoward
Copy link
Contributor

Fixes the challange app by accepting an expiration data for the end of the challange and updating the internal logic occardingly

@CyberHoward CyberHoward marked this pull request as draft September 30, 2023 17:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d1d5df7
Status:⚡️  Build in progress...

View logs

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cw_utils::Expiration seems much more flexible!

modules/contracts/apps/challenge/src/msg.rs Outdated Show resolved Hide resolved
modules/contracts/apps/challenge/src/state.rs Outdated Show resolved Hide resolved
modules/contracts/apps/challenge/src/handlers/execute.rs Outdated Show resolved Hide resolved
modules/contracts/apps/challenge/src/state.rs Outdated Show resolved Hide resolved
@Buckram123
Copy link
Collaborator

@CyberHoward

@CyberHoward CyberHoward merged commit 330002d into main Oct 19, 2023
15 of 17 checks passed
@CyberHoward CyberHoward deleted the fix/challange_app branch October 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants