-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/add osmosis test tube #150
Conversation
Deploying with Cloudflare Pages
|
Codecov Report
|
Removed default feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's so little code for an integration, pretty awesome.
Is there any pre-setup required to executing with this? I.e. is the binary included in the package or does the user need to install anything before they can run this? If so it should be clearly documented somewhere.
cw-orch/src/test_tube/core.rs
Outdated
|
||
pub use osmosis_test_tube; | ||
|
||
/// Wrapper around a cw-multi-test [`App`](cw_multi_test::App) backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These doc comments should be updated
cw-orch/src/test_tube/core.rs
Outdated
|
||
impl TestTube<MockState> { | ||
/// Create a mock environment with the default mock state. | ||
pub fn new(init_coins: Vec<Coin>) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To who are these init coins minted? Add some doc comment on that
cw-orch/src/test_tube/response.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems empty
Oh and can we rename TestTube to OsmosisTestTube? I think the idea of test-tube is to allow other chains to use it as well, so there could be a NeutronTestTube, etc. |
And could you add a usage example in /cw-orch/examples ? You need to add it to the cargo.toml as well and set the feature requirement |
Done |
This PR aims at providing Osmosis-test-tube as an additional chain for cw-orch.
This new chain is very similar to cw-multi-test but tests against actual on-chain logic.
Basic counter tests have been provided