Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/add osmosis test tube #150

Merged
merged 11 commits into from
Jul 9, 2023
Merged

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Jul 5, 2023

This PR aims at providing Osmosis-test-tube as an additional chain for cw-orch.
This new chain is very similar to cw-multi-test but tests against actual on-chain logic.
Basic counter tests have been provided

@Kayanski Kayanski marked this pull request as ready for review July 5, 2023 11:20
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a82f21a
Status: ✅  Deploy successful!
Preview URL: https://7e2c3512.cw-orchestrator.pages.dev
Branch Preview URL: https://update-add-osmosis-test-tube.cw-orchestrator.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #150 (91c09b9) into main (458b42a) will decrease coverage by 0.7%.
The diff coverage is 50.2%.

❗ Current head 91c09b9 differs from pull request most recent head a82f21a. Consider uploading reports for the commit a82f21a to get more accurate results

Impacted Files Coverage Δ
cw-orch/src/error.rs 16.6% <ø> (ø)
cw-orch/src/keys/private.rs 79.5% <ø> (ø)
cw-orch/src/lib.rs 100.0% <ø> (ø)
cw-orch/src/test_tube/core.rs 50.2% <50.2%> (ø)

... and 1 file with indirect coverage changes

@Kayanski Kayanski requested a review from CyberHoward July 5, 2023 16:04
Removed default feature
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's so little code for an integration, pretty awesome.

Is there any pre-setup required to executing with this? I.e. is the binary included in the package or does the user need to install anything before they can run this? If so it should be clearly documented somewhere.


pub use osmosis_test_tube;

/// Wrapper around a cw-multi-test [`App`](cw_multi_test::App) backend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These doc comments should be updated


impl TestTube<MockState> {
/// Create a mock environment with the default mock state.
pub fn new(init_coins: Vec<Coin>) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To who are these init coins minted? Add some doc comment on that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems empty

@CyberHoward
Copy link
Contributor

Oh and can we rename TestTube to OsmosisTestTube? I think the idea of test-tube is to allow other chains to use it as well, so there could be a NeutronTestTube, etc.

README.md Outdated Show resolved Hide resolved
@CyberHoward
Copy link
Contributor

And could you add a usage example in /cw-orch/examples ? You need to add it to the cargo.toml as well and set the feature requirement

@Kayanski
Copy link
Contributor Author

Kayanski commented Jul 8, 2023

Done

@CyberHoward CyberHoward merged commit f14547b into main Jul 9, 2023
@CyberHoward CyberHoward deleted the update/add-osmosis-test-tube branch July 9, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants