Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Downcast CwOrchError #159

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Feature/Downcast CwOrchError #159

merged 3 commits into from
Jul 17, 2023

Conversation

Buckram123
Copy link
Contributor

This PR aims to add a downcast function for CwOrchError
This allows comparing errors in tests

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 14, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15a52a0
Status: ✅  Deploy successful!
Preview URL: https://3391dc2e.cw-orchestrator.pages.dev
Branch Preview URL: https://downcast-cw-orch-error.cw-orchestrator.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #159 (15a52a0) into main (a3edf57) will increase coverage by 0.0%.
The diff coverage is 88.8%.

Impacted Files Coverage Δ
cw-orch/src/error.rs 57.1% <87.5%> (+40.4%) ⬆️
contracts/counter/src/error.rs 100.0% <100.0%> (+100.0%) ⬆️

CyberHoward
CyberHoward approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah preferably we wouldn't have an anyerror variant but cw-multi-test uses it so we have to as well...

@CyberHoward CyberHoward merged commit 684a69b into main Jul 17, 2023
@CyberHoward CyberHoward deleted the downcast-cw_orch-error branch July 17, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberHoward CyberHoward CyberHoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Buckram123 @CyberHoward