Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #168, #199 #201

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix issues #168, #199 #201

merged 3 commits into from
Sep 4, 2023

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Sep 1, 2023

This PR aims at fixing small issues

Closes #199 : Better errors for getting events in Tx object
Closes #168 : Adding Osmosis_1 support

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0692b41
Status: ✅  Deploy successful!
Preview URL: https://ad84f2f1.cw-orchestrator.pages.dev
Branch Preview URL: https://update-fix-bugs.cw-orchestrator.pages.dev

View logs

@Kayanski Kayanski marked this pull request as ready for review September 1, 2023 11:59
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #201 (0692b41) into main (f36215b) will increase coverage by 0.4%.
Report is 656 commits behind head on main.
The diff coverage is 66.5%.

Files Changed Coverage Δ
contracts/counter/src/interface.rs 0.0% <0.0%> (ø)
contracts/mock_contract/src/custom_resp.rs 0.0% <0.0%> (ø)
cw-orch-daemon/src/proto/injective.rs 0.0% <0.0%> (ø)
cw-orch-daemon/src/queriers/feegrant.rs 0.0% <0.0%> (ø)
packages/cw-orch-core/src/contract/deploy.rs 0.0% <0.0%> (ø)
packages/cw-orch-networks/src/networks/mod.rs 0.0% <0.0%> (ø)
cw-orch-daemon/src/queriers/ibc.rs 3.0% <3.0%> (ø)
cw-orch-daemon/src/queriers/gov.rs 13.5% <13.5%> (ø)
cw-orch-daemon/src/error.rs 14.2% <14.2%> (ø)
cw-orch-daemon/src/queriers/staking.rs 16.3% <16.3%> (ø)
... and 42 more

Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

Comment on lines +90 to +93
Err(StdError::generic_err(format!(
"missing combination (event: {}, attribute: {})",
event_type, attr_key
)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer!

Comment on lines +10 to +20
pub const OSMOSIS_1: ChainInfo = ChainInfo {
kind: ChainKind::Mainnet,
chain_id: "osmois-1",
gas_denom: "uosmo",
gas_price: 0.025,
grpc_urls: &["http://grpc.osmosis.zone:9090"],
network_info: OSMO_NETWORK,
lcd_url: None,
fcd_url: None,
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Kayanski Kayanski merged commit 040cb04 into main Sep 4, 2023
17 of 18 checks passed
@Kayanski Kayanski deleted the update/fix-bugs branch September 4, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update event_attr_value's error to know which key is missing Add osmosis mainnet ChainInfo to networks
3 participants