Fix TLS issues #484
Merged
Fix TLS issues #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with
|
| Latest commit: |
8a4af81
|
| Status: | ⚡️ Build in progress... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
CyberHoward
requested review from
Buckram123 and
Kayanski
and removed request for
Buckram123
Kayanski
approved these changes
Sep 5, 2024
| @@ -45,7 +45,7 @@ bech32 = { version = "0.11.0", default-features = false, features = ["alloc"] } | |||
| hex = { version = "0.4.3" } | |||
| ripemd = { version = "0.1.3" } | |||
| tokio = { workspace = true, features = ["full"] } | |||
| tonic = { workspace = true, features = ["tls", "tls-roots"] } | |||
| tonic = { workspace = true, features = ["tls"] } | |||
There was a problem hiding this comment.
Reallt removing the tls roots here ?
There was a problem hiding this comment.
It works without so not sure why we should enable it.
| @@ -2,7 +2,8 @@ use cosmrs::proto::cosmos::base::tendermint::v1beta1::{ | |||
| service_client::ServiceClient, GetNodeInfoRequest, | |||
| }; | |||
| use cw_orch_core::{environment::ChainInfoOwned, log::connectivity_target}; | |||
| use tonic::transport::{Channel, ClientTlsConfig}; | |||
| use http::Uri; | |||
There was a problem hiding this comment.
Have you tried this new code with http:// prefixed URIs ?
There was a problem hiding this comment.
Yes, see the tests in query_only.rs. There's a http and https test there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the TLS related issues that we've ran into for https URLs