Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added upload wasm function to sender #487

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Added upload wasm function to sender #487

merged 12 commits into from
Sep 16, 2024

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Sep 11, 2024 •
edited
Loading

This PR adds a upload_wasm function to CosmosSender for uploading wasm code associated to no Contract structure

Checklist

  • Changelog updated.
  • Docs updated.

@Kayanski Kayanski mentioned this pull request Sep 11, 2024
Merged
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2024 •
edited
Loading

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ac19ce
Status:⚡️  Build in progress...

View logs

CyberHoward
CyberHoward requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this function to just be added to the CosmosSender instead of being included in the core sender traits.

Buckram123
Buckram123 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kayanski Kayanski merged commit dafd9b6 into main Sep 16, 2024
9 of 13 checks passed
@Kayanski Kayanski deleted the nicolas/orc-166-wasmpath-should-implement-uploadable branch September 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberHoward CyberHoward CyberHoward requested changes

@Buckram123 Buckram123 Buckram123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kayanski @CyberHoward @Buckram123