Updated to syn 2.0 #488
Merged
Updated to syn 2.0 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with
|
| Latest commit: |
6975f00
|
| Status: | ⚡️ Build in progress... |
CyberHoward
reviewed
Sep 13, 2024
| pub(crate) fn parse_enum_attributes(item_enum: &ItemEnum) -> EnumAttributes { | ||
| let mut enum_attributes = EnumAttributes::default(); | ||
| for attr in &item_enum.attrs { | ||
| if attr.path().is_ident("cw_orch") { |
There was a problem hiding this comment.
So in syn2 the namespacing of macros is refered to as the "ident"?
There was a problem hiding this comment.
Yes ! This is directly inspired from the official syn2 docs
…ve-to-2nd-version
Kayanski
deleted the
nicolas/orc-155-bump-syn-in-cw-orch-fns-derive-to-2nd-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at updating syn to 2.0 and putting in common the attributes parsing for all attribute levels.
Common parsing for all attributes level is motivated by the following issue on syn 2.0 : dtolnay/syn#1426
Checklist