-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distant wasm upload #489
base: main
Are you sure you want to change the base?
Conversation
Deploying cw-orchestrator with Cloudflare Pages
|
@@ -0,0 +1,183 @@ | |||
const ARM_POSTFIX: &str = "-aarch64"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a copy of the old artifacts_dir module inside wasm_path.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised by how much code was changed for this feature, and it's breaking to cw-orch-core.
is there no alternative way that we could structure this PR to make it non-breaking?
Yes. this was done to propose a preliminary implementation. |
And what about separating the fetching from the rest of the logic? I.e. adding a fn or object that you can use to fetch any wasm blob and store it in the local / configured artifacts folder? I guess that complicates other things like sharing the crate and then needing to resolve where to store + retrieve the file... |
This PR aims at providing integrators with more methods to query the wasms to upload on chain.
Checklist