Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CosmosSigner default implementation #494

Conversation

Kayanski
Copy link
Contributor

This PR aims at making the TxBroadcaster available to other types of Signers that want to implement their own signing logic, very close to the CosmosSender signing logic.

This implementation is done to accomodate for Xion Senders that have a different signing mechanism

Checklist

  • Changelog updated.
  • Docs updated.

Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc63c02
Status: ✅  Deploy successful!
Preview URL: https://4e8df1ee.cw-orchestrator.pages.dev
Branch Preview URL: https://nicolas-orc-171-parse-respon.cw-orchestrator.pages.dev

View logs

@Kayanski Kayanski marked this pull request as ready for review September 26, 2024 13:34
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 89.24051% with 17 lines in your changes missing coverage. Please review.

Project coverage is 56.8%. Comparing base (5fe212f) to head (7125879).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cw-orch-daemon/src/senders/cosmos.rs 85.7% 8 Missing ⚠️
cw-orch-daemon/src/senders/sign.rs 92.8% 4 Missing ⚠️
cw-orch-daemon/src/tx_builder.rs 86.3% 3 Missing ⚠️
cw-orch-daemon/src/tx_broadcaster.rs 71.4% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
cw-orch-daemon/src/senders/tx.rs 100.0% <100.0%> (ø)
cw-orch-daemon/src/tx_broadcaster.rs 75.7% <71.4%> (ø)
cw-orch-daemon/src/tx_builder.rs 71.1% <86.3%> (+0.1%) ⬆️
cw-orch-daemon/src/senders/sign.rs 92.8% <92.8%> (ø)
cw-orch-daemon/src/senders/cosmos.rs 43.0% <85.7%> (-14.2%) ⬇️

... and 5 files with indirect coverage changes

@Kayanski
Copy link
Contributor Author

@CyberHoward had to modify the trait slightly to be able to merge with main and the corrected authz capabilities

@Kayanski Kayanski merged commit f2cd8b6 into main Oct 1, 2024
13 checks passed
@Kayanski Kayanski deleted the nicolas/orc-171-parse-response-code-and-print-raw_log-if-not-code-0 branch October 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants