Add support for top level inputs #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odeGraphs (a Document is a GraphElement). Once discovered the proper value and path can be pulled from the interface. The path is important since global uniform update relies on path matching.
kwokcb
commented
Aug 16, 2023
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Aug 18, 2023
jstone-lucasfilm
merged commit b23de80
into
AcademySoftwareFoundation:main
12 checks passed
This was referenced Aug 18, 2023
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
Fix so that top level inputs are parsed properly and values and path reflection data is correct (for uniform updates).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix so that top level inputs are parsed properly and values and path reflection data is correct (for uniform updates).
Fixes:
emission_coloris connected but not rendering correctly? #1445Defaults
Fix top level input discovery to include
GraphElements and not justNodeGraphs (aDocumentwhere top level inputs reside is aGraphElement).Once discovered the proper value and path can be pulled from the interface. The path is important since global uniform update relies on path matching.
Tests
Added in a simple top level test:
stdlib/nodegraph_inputs/top_level_input.mtlxResult in MaterialXView:
Result in MaterialX Graph Editor:
Test files From Issues
1445
1383
