MDL 1.9 updates #2102
MDL 1.9 updates #2102
Conversation
krohmerNV
force-pushed
the
PR-mdl-1.9-update
branch
from
0e446cb
to
da4f101
Compare
…tion from material IOR Minor updates: - improve MDL printing by adding named parameters - handle 1-element mixes (basically scale) above layers - improve blur and hight to normal to return something meaningful (before totally broken) - improve non-material outputs that can be rendered, e.g. float3x3 and float4x4
krohmerNV
force-pushed
the
PR-mdl-1.9-update
branch
from
10412ee
to
1bebc31
Compare
There was a problem hiding this comment.
Overall looks good to me - I left a couple of small notes below - but nothing major.
I don't have a way to test the MDL backend at the moment - so relying on the unit tests and you to validate its generating the correct images etc, but code structure etc looks good to me.
There was a problem hiding this comment.
This looks like a great set of improvements, thanks @krohmerNV, and I had just a few recommendations for edits.
| @@ -0,0 +1,372 @@ | |||
| /* | |||
| * Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
Would it be acceptable to use the latest MaterialX project copyright for this new file? Here's the text of that copyright notice for reference:
//
// Copyright Contributors to the MaterialX Project
// SPDX-License-Identifier: Apache-2.0
//
There was a problem hiding this comment.
I need to check. I do think so but I want to make sure.
| // this produces NaN | ||
| float nx = S[0] - S[2] + (2.0*S[3]) - (2.0*S[5]) + S[6] - S[8]; | ||
| float ny = S[0] + (2.0*S[1]) + S[2] - S[6] - (2.0*S[7]) - S[8]; | ||
| // float nz = scale * ::math::sqrt(1.0 - nx*nx - ny*ny); |
There was a problem hiding this comment.
Would it make sense to remove this unused original logic, since GitHub itself preserves the history of this file?
There was a problem hiding this comment.
This code is ends up being part of the data library - right? if so then it will be installed in locations that aren't attached to any git repo - so perhaps this is a case where keeping comments around that help keep the code more readable is a reasonable step?
git history is not always the easiest place to find documentation.
add new version to GenMDL and remove uniform restriction from material IOR
Minor updates: