Fix lastest msys2 windows build #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Laberge <[email protected]>
bernie-laberge
force-pushed
the
fix_latest_msys2_windows_build
branch
from
fc0f28d
to
012d7fc
Compare
cedrik-fuoco-adsk
approved these changes
Nov 13, 2023
geffrak
approved these changes
Nov 13, 2023
bernie-laberge
merged commit b211b26
into
AcademySoftwareFoundation:main
2 checks passed
rogernelson
reviewed
Nov 14, 2023
| @@ -47,7 +47,7 @@ RV_BUILD_PARALLELISM="${RV_BUILD_PARALLELISM:-$(python3 -c 'import os; print(os. | |||
|
|
|||
| # ALIASES: Basic commands | |||
|
|
|||
| alias rvsetup="python3 -m pip install --user --upgrade -r ${RV_HOME}/requirements.txt" | |||
| alias rvsetup="SETUPTOOLS_USE_DISTUTILS=${SETUPTOOLS_USE_DISTUTILS} python3 -m pip install --user --upgrade -r ${RV_HOME}/requirements.txt" | |||
There was a problem hiding this comment.
Could that cause issues with non-Windows?
There was a problem hiding this comment.
I tested it on Mac and it is working fine : SETUPTOOLS_USE_DISTUTILS=
mchesnay
pushed a commit
to mchesnay/OpenRV
that referenced
this pull request
Nov 27, 2023
### Fix lastest msys2 windows build ### Linked issues NA ### Summarize your change. - Added the required SETUPTOOLS_USE_DISTUTILS=stdlib instruction to the documentation when installing the python requirements on Windows - Fixed the rvsetup alias so that on Windows, it contains the required SETUPTOOLS_USE_DISTUTILS=stdlib instruction. - Added a note to indicate that XCode 14.3.1 must be used to build Open RV on Mac (as FFmpeg cannot be built with a more recent XCode version such as XCode 15 for example) - Added a graphical icon to indicate which msys2 shell to use to build RV. - Added the new ACLOCAL_PATH env var requirement to build RV to the windows build instructions. ### Describe the reason for the change. A recent msys2 update made Open RV fail to build when installed. ### Describe what you have tested and on which operating system. Successful build was validated on Windows and Mac ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Martin Chesnay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lastest msys2 windows build
Linked issues
NA
Summarize your change.
Describe the reason for the change.
A recent msys2 update made Open RV fail to build when installed.
Describe what you have tested and on which operating system.
Successful build was validated on Windows and Mac
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.