-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#578: Update to FFmpeg 7.1 #599
Merged
bernie-laberge
merged 5 commits into
AcademySoftwareFoundation:main
from
williamwira:review-wwira-578
Oct 22, 2024
Merged
#578: Update to FFmpeg 7.1 #599
bernie-laberge
merged 5 commits into
AcademySoftwareFoundation:main
from
williamwira:review-wwira-578
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamwira
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
September 30, 2024 14:44
williamwira
force-pushed
the
review-wwira-578
branch
from
September 30, 2024 19:17
346d60e
to
19b93b5
Compare
williamwira
changed the title
#578: Update to FFmpeg 7.0.2 WIP
#578: Update to FFmpeg 7.0.2
Sep 30, 2024
williamwira
force-pushed
the
review-wwira-578
branch
2 times, most recently
from
October 2, 2024 11:17
277da13
to
c65fd0c
Compare
williamwira
force-pushed
the
review-wwira-578
branch
3 times, most recently
from
October 2, 2024 15:43
b150cd2
to
6140261
Compare
williamwira
force-pushed
the
review-wwira-578
branch
from
October 4, 2024 00:36
6140261
to
aaf8b26
Compare
williamwira
force-pushed
the
review-wwira-578
branch
from
October 4, 2024 23:56
aaf8b26
to
2bba2f9
Compare
bernie-laberge
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for this excellent contribution to Open RV Will !
williamwira
force-pushed
the
review-wwira-578
branch
from
October 15, 2024 21:08
3033c04
to
5db54c1
Compare
williamwira
force-pushed
the
review-wwira-578
branch
from
October 16, 2024 20:33
2a0393e
to
870af8f
Compare
cedrik-fuoco-adsk
approved these changes
Oct 18, 2024
eloisebrosseau
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, but this is really great! Thank you Will!
williamwira
force-pushed
the
review-wwira-578
branch
from
October 18, 2024 17:05
870af8f
to
c985182
Compare
williamwira
force-pushed
the
review-wwira-578
branch
from
October 18, 2024 21:12
e15dc1e
to
22ae9bc
Compare
Upgrade ffmpeg to 7.1. Fix deprecation errors and warnings when building with FFmpeg 7.1. n/a Maintenance Update MacOS Signed-off-by: Will Wira <[email protected]>
Optionally use build flag RV_FFMPEG to select desired major version to build. Build example: rvcfg -DRV_FFMPEG=7 Supported versions: 6 (default), 7 Signed-off-by: Will Wira <[email protected]>
Updated all text references to FFmpeg so they match the official product naming. Signed-off-by: Will Wira <[email protected]>
…SoftwareFoundation#578) * av_channel_name and av_channel_desc return values are valid for int > 0. * Update c-style arrays in MovieFFMpeg::idAudioChannels to std::array. Signed-off-by: Will Wira <[email protected]>
Include array header Signed-off-by: Will Wira <[email protected]>
williamwira
force-pushed
the
review-wwira-578
branch
from
October 22, 2024 01:52
22ae9bc
to
58d2299
Compare
bernie-laberge
merged commit Oct 22, 2024
576d569
into
AcademySoftwareFoundation:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
Fixes #578
Summarize your change.
Upgraded FFmpeg to 7.1, and resolved build-time errors and deprecation warnings.
Added build flag RV_FFMPEG so app builder can decide between FFmpeg 6 and FFmpeg 7. (FFmpeg 6 is default)
Describe the reason for the change.
Maintenance Update
Describe what you have tested and on which operating system.
MacOS Sonoma 14.7
Linux RHEL 9.2
Add a list of changes, and note any that might need special attention during the review.
MovieFFMpeg
ffmpeg.cmake
Build with no RV_FFMPEG flag to build against FFmpeg 6, or do
rvcfg -DRV_FFMPEG=7
to use FFmpeg 7.After building: Open RV, load a QuickTime video file. Confirm the video loads and can be played.