Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong sample Python code, closes #1694 #1695

Conversation

mm3509
Copy link

@mm3509 mm3509 commented Feb 10, 2024

Fixes #1694

Summarize your change.

The sample Python code threw an error. The changed code now works. The solution is from StackOverflow.

Reference associated tests.

This PR is about documentation and the README, so I did not run tests.

Copy link

linux-foundation-easycla bot commented Feb 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7302ff1) 79.84% compared to head (c422436) 79.84%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         197      197           
  Lines       21796    21796           
  Branches     4358     4358           
=======================================
  Hits        17403    17403           
  Misses       2232     2232           
  Partials     2161     2161           
Flag Coverage Δ
py-unittests 79.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7302ff1...c422436. Read the comment docs.

@mm3509 mm3509 force-pushed the 1694-fix-sample-python-code branch from c422436 to 6477809 Compare February 10, 2024 17:31
@mm3509 mm3509 closed this Feb 10, 2024
@mm3509
Copy link
Author

mm3509 commented Feb 10, 2024

Closing after comments by Jean-Christophe at #1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants