Handle non atomic write method when writing on network fs with linux #991
Conversation
| if attempt == 0: | ||
| except OSError as e: | ||
| # If we are writing to the network, we can't ensure atomicity | ||
| if e.errno == 22: |
There was a problem hiding this comment.
Error no. 22 is an invalid filepath, right? What does that have to do with network paths?
There was a problem hiding this comment.
The goal is to handle the sync method error of atomicwrites:
File "/usr/local/lib/python3.7/site-packages/rez/vendor/atomicwrites/init.py", line 44, in _sync_directory
_proper_fsync(fd)
OSError: [Errno 22] Invalid argument
This is ugly, but atomicwrites doesn't handle properly this error itself
|
Hey @jlorrain thanks for finding this and providing a fix. I think this |
|
Closing in lieu of #998 |
Linux doesn't provide a sync method for network mounted fs, which cause atomicwrites to fail.
I added a failsafe to write with a basic (non atomic) method for that edge case
Fix issue #858