Upgrade rust 1.74

.github/workflows/benchmark.yml

@@ -26,7 +26,7 @@ jobs:
               ref: data.data.head.ref,
               sha: data.data.head.sha,
             }
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           ref: ${{ fromJson(steps.issue.outputs.result).sha }}

.github/workflows/coverage.yml

@@ -27,7 +27,7 @@ jobs:
     runs-on: [self-hosted, linux]
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           submodules: recursive
       - uses: actions/cache@v3
@@ -52,7 +52,7 @@ jobs:
             acala-primitives \
             acala-rpc \
             acala-runtime runtime-common runtime-integration-tests karura-runtime mandala-runtime \
-            ethjson evm-jsontests jsontests \
+            ethjson evm-jsontests \
             --exclude-files **/mock.rs **/weights.rs **/weights/* --out xml
       - name: Upload to codecov.io
         uses: codecov/codecov-action@v3

.github/workflows/docker-build-internal.yml

@@ -15,7 +15,7 @@ jobs:
       matrix:
         network: [mandala, karura, acala]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.inputs.branch || github.ref }}
           submodules: recursive

.github/workflows/docker-build-production.yml

@@ -32,7 +32,7 @@ jobs:
       matrix: ${{ steps.docker-setup-matrix.outputs.matrix }}
       version: ${{ steps.docker-setup-matrix.outputs.version }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
@@ -52,7 +52,7 @@ jobs:
     strategy:
       matrix: ${{fromJson(needs.setup-matrix.outputs.matrix)}}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.inputs.branch || github.ref }}
           submodules: recursive

.github/workflows/docker-build-profiling.yml

@@ -12,7 +12,7 @@ jobs:
     name: "Build docker profiling image for acala"
     runs-on: self-hosted
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.inputs.branch || github.ref }}
           submodules: recursive

.github/workflows/extrinsic-ordering-check-from-bin.yml

@@ -27,7 +27,7 @@ jobs:
       IMAGE: ${{ github.event.inputs.image }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - uses: actions/setup-node@v4

.github/workflows/extrinsic-ordering-check-on-release.yml

@@ -36,7 +36,7 @@ jobs:
   check-extrinsic-ordering-on-release:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive

.github/workflows/publish-release.yml

@@ -52,7 +52,7 @@ jobs:
     steps:
       # Checkout the Acala codebase
       - name: Checkout Codebase
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: true
@@ -69,7 +69,7 @@ jobs:
       # Build WASM with Substrate Runtime Tool
       - name: Srtool build
         id: srtool_build
-        uses: chevdor/[email protected].0
+        uses: chevdor/[email protected].1
         env:
           BUILD_OPTS: "--features on-chain-release-build,no-metadata-docs"
         with:

.github/workflows/update-tokens.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           persist-credentials: false

.github/workflows/verify-bootnotes.yml

@@ -8,7 +8,7 @@ jobs:
   verify-karura:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: verify bootnotes
@@ -17,7 +17,7 @@ jobs:
   verify-acala:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: verify bootnotes

modules/liquid-crowdloan/src/tests.rs

@@ -32,6 +32,7 @@ fn redeem_works() {
 		.balances(vec![(BOB, LCDOT, 100), (LiquidCrowdloan::account_id(), DOT, 100)])
 		.build()
 		.execute_with(|| {
+			assert_eq!(Currencies::free_balance(LCDOT, &BOB), 100);
 			assert_ok!(LiquidCrowdloan::redeem(RuntimeOrigin::signed(BOB), 100));
 			assert_eq!(Currencies::free_balance(LCDOT, &BOB), 0);
 			assert_eq!(Currencies::free_balance(DOT, &BOB), 100);
@@ -119,6 +120,7 @@ fn set_redeem_currency_id() {
 				LDOT
 			));
 
+			assert_eq!(Currencies::free_balance(LCDOT, &ALICE), 100);
 			assert_err!(
 				LiquidCrowdloan::redeem(RuntimeOrigin::signed(ALICE), u128::MAX),
 				sp_runtime::ArithmeticError::Overflow

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.73.0"
+channel = "1.74.0"
 components = ["rustfmt", "clippy"]
 targets = ["wasm32-unknown-unknown"]