Support bytestring-0.11.3.0 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can see, the same Bytestring update also added "take", right? |
This conditionally removes polyfills that clash with the new, actual upstream variants.
tomsmeding
force-pushed
the
bytestring-11-3
branch
from
4cc258d
to
f0cc77e
Compare
|
@dpvanbalen Thanks for having a look! After personal communication, I updated the diff to what we agreed. Looks good? |
dpvanbalen
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses CPP to remove a polyfill for
takeWhileonShortByteString, that was necessary beforebytestring-0.11.3.0but is now provided by the source package.Motivation and context
Compatibility.
How has this been tested?
It builds here :)
Types of changes
Checklist: