Merge pull request #1917 from Accenture/bug/1916-deleting-dataextensi…

…onfield-with-in-name-does-not-work bug/1916 fix keys with ":" cannot be found
Accenture · Dec 6, 2024 · b92241a · b92241a
2 parents dfb82fb + ba70eae
commit b92241a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 10 deletions.
diff --git a/@types/lib/index.d.ts.map b/@types/lib/index.d.ts.map
diff --git a/lib/index.js b/lib/index.js
@@ -2221,36 +2221,53 @@ class Mcdev {
         }
         const metadataOptionMap = metadataOption.map((item) => {
             const itemArr = item.split(':');
+            const type = itemArr.shift();
             switch (itemArr.length) {
-                case 1: {
-                    return { type: itemArr[0] };
+                case 0: {
+                    // no ":" found
+                    return { type };
                 }
-                case 2: {
+                case 1: {
+                    // 1 ":" found
                     if (allowedIdentifiers.includes('key')) {
-                        return { type: itemArr[0], key: itemArr[1] };
+                        return { type, key: itemArr[0] };
                     }
                     break;
                 }
-                case 3: {
-                    switch (itemArr[1]) {
+                default: {
+                    // 2 or more ":" found
+                    switch (itemArr[0]) {
                         case 'key':
                         case 'k': {
                             if (allowedIdentifiers.includes('key')) {
-                                return { type: itemArr[0], key: itemArr[2] };
+                                // remove k/key
+                                itemArr.shift();
+                                return { type, key: itemArr.join(':') };
                             }
                             break;
                         }
                         case 'id':
                         case 'i': {
                             if (allowedIdentifiers.includes('id')) {
-                                return { type: itemArr[0], id: itemArr[2] };
+                                // remove i/id
+                                itemArr.shift();
+                                return { type, id: itemArr.join(':') };
                             }
                             break;
                         }
                         case 'name':
                         case 'n': {
                             if (allowedIdentifiers.includes('name')) {
-                                return { type: itemArr[0], name: itemArr[2] };
+                                // remove n/name
+                                itemArr.shift();
+                                return { type, name: itemArr.join(':') };
+                            }
+                            break;
+                        }
+                        default: {
+                            // assume ":" is part of the key (e.g. possible for DE-fields)
+                            if (allowedIdentifiers.includes('key')) {
+                                return { type, key: itemArr.join(':') };
                             }
                         }
                     }