Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DP-938][DP-939][DP-943][DP-944][DP-945][DP-946][DP-947][DP-948][DP-951][DP-954] Put back Rename Column Logic With Truncation #3

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

yannistze
Copy link
Collaborator

@yannistze yannistze commented Oct 18, 2024

Reverting the qualifier names usage introduced here because it created Duplicate Column name issues and required more refactoring.

Remediating (for now) by truncating the query and the column naming conventions which at least gets us to a better spot and opened up memsql#93

Test Notes

  • sbt "clean; compile"
[success] Total time: 25 s, completed Oct 18, 2024, 4:35:27 PM
  • sbt "testOnly com.singlestore.spark.SQLPushdownTest"
[info] Run completed in 31 minutes, 51 seconds.
[info] Total number of tests run: 811
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 811, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 1920 s (32:00), completed Oct 18, 2024, 5:07:41 PM
  • sbt "testOnly com.singlestore.spark.SQLPushdownTestAiq"
[info] Run completed in 41 minutes, 44 seconds.
[info] Total number of tests run: 1684
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1684, failed 0, canceled 0, ignored 21, pending 0
[info] All tests passed.
[success] Total time: 2505 s (41:45), completed Oct 18, 2024, 5:51:52 PM

Deploy Notes

  • Merge to master
  • sbt "clean; compile; publish;"
  • Pickup in Flame

@yannistze yannistze requested a review from MasterDDT October 18, 2024 22:32
@yannistze yannistze merged commit 63694ea into master Oct 18, 2024
@yannistze yannistze deleted the singleStoreColNamesFix branch October 18, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants