Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morgan - Leaves #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
343 changes: 244 additions & 99 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Node
attr_reader :data # allow external entities to read value but not write
attr_accessor :next # allow external entities to read or write next node

def initialize(value, next_node = nil)
@data = value
@next = next_node
Expand All @@ -12,120 +12,265 @@ def initialize(value, next_node = nil)

# Defines the singly linked list
class LinkedList
def initialize
@head = nil # keep the head private. Not accessible outside this class
def initialize
@head = nil # keep the head private. Not accessible outside this class
end

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
def add_first(value)
@head = Node.new(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to attach the new node to the rest of the list.

Suggested change
@head = Node.new(value)
@head = Node.new(value, @head)

end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
def search(value)
current = @head

until current.nil?
return true if current.data == value
current = current.next
end

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
def add_first(value)
raise NotImplementedError
return false
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max
if @head == nil
return nil
end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
def search(value)
raise NotImplementedError

current = @head
max = @head.data

until current == nil
if current.data > max
max = current.data
end
current = current.next
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max
raise NotImplementedError
return max
end

# method to return the min value in the linked list
# returns the data value and not the node
def find_min
if @head == nil
return nil
end

# method to return the min value in the linked list
# returns the data value and not the node
def find_min
raise NotImplementedError

current = @head
min = @head.data

until current == nil
if current.data < min
min = current.data
end
current = current.next
end


# method that returns the length of the singly linked list
def length
raise NotImplementedError
return min
end


# method that returns the length of the singly linked list
def length
if @head.nil?
return 0
end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
def get_at_index(index)
raise NotImplementedError

current = @head
count = 0

until current.nil?
count += 1
current = current.next
end

# method to print all the values in the linked list
def visit
raise NotImplementedError
return count
end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
def get_at_index(index)
current = @head

index.times do
return nil if current.nil?
current = current.next
end

# method to delete the first node found with specified value
def delete(value)
raise NotImplementedError

return current.data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current might be nil

Suggested change
return current.data
return nil if current.nil?
return current.data

end

# method to print all the values in the linked list
def visit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head

until current.nil?
print current.data
end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
def reverse
raise NotImplementedError
end

# method to delete the first node found with specified value
def delete(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head
previous = nil

if current == nil
return nil
end


## Advanced Exercises
# returns the value at the middle element in the singly linked list
def find_middle_value
raise NotImplementedError

until current.data == value
return nil if current.nil?
previous = current
current = current.next
end

# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
def find_nth_from_end(n)
raise NotImplementedError
if previous == nil
@head = current.next
else
previous.next = current.next
end

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
def has_cycle
raise NotImplementedError
end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
def reverse

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return if @head.nil?
current = @head
previous = nil
temp = nil

until current.next.nil?
temp = current.next
current.next = previous
previous = current
current = temp
end


# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
def get_first
raise NotImplementedError

current.next = previous
@head = current
end


## Advanced Exercises
# returns the value at the middle element in the singly linked list
def find_middle_value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

length = self.length

return nil if @head.nil?

if length % 2 == 0
value = (length / 2) - 1
else
value = (length / 2)
end

# method that inserts a given value as a new last node in the linked list
def add_last(value)
raise NotImplementedError
return self.get_at_index(value)
end

# find the nth node from the end and return it s value
# assume indexing starts at 0 while counting to n
def find_nth_from_end(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head
n_from_end = @head

return nil if current.nil?

n.times do
return nil if n_from_end.next.nil?
n_from_end = n_from_end.next
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
def get_last
raise NotImplementedError
until n_from_end.next.nil?
return current.data if current.next.nil?
current = current.next
n_from_end = n_from_end.next
end

# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
def insert_ascending(value)
raise NotImplementedError
return current.data
end

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
def has_cycle
raise NotImplementedError
end


# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if @head.nil?
return nil
else
return @head.data
end

# Helper method for tests
# Creates a cycle in the linked list for testing purposes
# Assumes the linked list has at least one node
def create_cycle
return if @head == nil # don't do anything if the linked list is empty

# navigate to last node
current = @head
while current.next != nil
current = current.next
end

# method that inserts a given value as a new last node in the linked list
def add_last(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head

if current.nil?
@head = Node.new(value)
return @head
end

until current.next == nil
current = current.next
end
current.next = Node.new(value)
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head

return nil if current.nil?

until current.next.nil?
current = current.next
end

return current.data
end

# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
def insert_ascending(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head

if current.nil?
return @head = Node.new(value)
end

until current.nil?
if value >= current.data && value < current.next.data
new_node = Node.new(value, current.next)
current.next = new_node
return
else
current = current.next
end

current.next = @head # make the last node link to first node
end
end
current = Node.new(value)
end

# Helper method for tests
# Creates a cycle in the linked list for testing purposes
# Assumes the linked list has at least one node
def create_cycle
return if @head == nil # don't do anything if the linked list is empty

# navigate to last node
current = @head
while current.next != nil
current = current.next
end

current.next = @head # make the last node link to first node
end
end