-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaves-Yasmin #27
base: master
Are you sure you want to change the base?
Leaves-Yasmin #27
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,30 +2,65 @@ class Queue | |||||||||||||||
|
||||||||||||||||
def initialize | ||||||||||||||||
# @store = ... | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
@store = Array.new(100) | ||||||||||||||||
@front = @back = -1 | ||||||||||||||||
# @front = -1 | ||||||||||||||||
# @back = -1 | ||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def enqueue(element) | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
if @front == -1 && @back == -1 | ||||||||||||||||
@front = 0 | ||||||||||||||||
@back = 1 | ||||||||||||||||
@store[@front] = element | ||||||||||||||||
elsif @front == @back | ||||||||||||||||
#DECIDE | ||||||||||||||||
raise ArgumentError, "Queue is full!" | ||||||||||||||||
else | ||||||||||||||||
@store[@back] = element | ||||||||||||||||
@back = (@back + 1) % @store.length | ||||||||||||||||
end | ||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def dequeue | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
if @front == @back | ||||||||||||||||
raise ArgumentError, "Queue is empty!" | ||||||||||||||||
end | ||||||||||||||||
if element = @store[@front] | ||||||||||||||||
@front = (@front + 1) % @store.length | ||||||||||||||||
return element | ||||||||||||||||
Comment on lines
+32
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem here is determining if the queue is empty or full because in either case front would be equal to back. So
Suggested change
|
||||||||||||||||
end | ||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def front | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
return @store[@front] | ||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def size | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
return @store.length | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This only gives you the length of the internal storage, not the size of the queue. |
||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def empty? | ||||||||||||||||
raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
# raise NotImplementedError, "Not yet implemented" | ||||||||||||||||
if @front == @back | ||||||||||||||||
return true | ||||||||||||||||
else | ||||||||||||||||
return false | ||||||||||||||||
end | ||||||||||||||||
Comment on lines
+50
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||
end | ||||||||||||||||
|
||||||||||||||||
def to_s | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||||||||||||
return @store.to_s | ||||||||||||||||
# return @store.to_s | ||||||||||||||||
queue = [] | ||||||||||||||||
until @front == @back | ||||||||||||||||
queue << @store[@front] | ||||||||||||||||
@front = (@front + 1) % @store.length | ||||||||||||||||
end | ||||||||||||||||
return queue.to_s | ||||||||||||||||
end | ||||||||||||||||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍