Branches - Erika #33
Open
Branches - Erika #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 10, 2020
lib/problems.rb
Outdated
Comment on lines
8
to
10
| openers = ["{", "[", "("] | ||
| closers = ["}", "]", ")"] | ||
|
|
There was a problem hiding this comment.
I suggest using a hash here instead of arrays where the key is an open brace and the value is the close.
lib/problems.rb
Outdated
Comment on lines
20
to
37
| until count == length || stack_size > string.length/2 | ||
| char = string[count] | ||
| # if the value is in openers, add to stack | ||
| if openers.include?(char) | ||
| stack.push(char) | ||
| stack_size += 1 | ||
| # if the value is in closers, pop from stack | ||
| else | ||
| if closers.include?(char) | ||
| stack.pop | ||
| stack_size -= 1 | ||
| # if it's in neither, return false | ||
| else | ||
| return false | ||
| end | ||
| end | ||
| count += 1 | ||
| end |
There was a problem hiding this comment.
You're on the right track here. I suggest, like I did above using a hash to match up open and close braces.
lib/queue.rb
Outdated
| def enqueue(element) | ||
| raise NotImplementedError, "Not yet implemented" | ||
| end | ||
| def enqueue(element) |
There was a problem hiding this comment.
What about when the queue is empty, and what about when it's full?
lib/queue.rb
Outdated
| end | ||
|
|
||
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| end | ||
|
|
||
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return true if @front == -1 && @rear == -1 |
There was a problem hiding this comment.
You're assuming the queue is empty if front and rear are -1, but your initialize method sets them to 0.
Also when you dequeue above if the queue is now empty, you would then need to set them to -1.
added 6 commits
August 9, 2020 07:30
…_first as push/pop for best time/space
CheezItMan
reviewed
Sep 14, 2020
Comment on lines
5
to
7
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def balanced(string) |
| end | ||
|
|
||
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| def dequeue |
| end | ||
|
|
||
| def front | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @store[@front] | ||
| end | ||
|
|
||
| def size |
Comment on lines
58
to
60
| def empty? | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return @front == @rear | ||
| end |
There was a problem hiding this comment.
I think this should actually be:
return @front == -1 && @rear == -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation