Leaves - Emily V #40
Open
Leaves - Emily V #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 10, 2020
Comment on lines
+3
to
5
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def balanced(string) |
Comment on lines
+30
to
32
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) <- but we'd probably use less assuming the expression contains operators | ||
| def evaluate_postfix(postfix_expression) |
| end | ||
|
|
||
|
|
||
| def enqueue(element) |
There was a problem hiding this comment.
This method could use being broken into some helper methods. Otherwise it seems to work.
| raise NotImplementedError, "Not yet implemented" | ||
| #resize if the array is full | ||
| if @front == (@back + 1) % @store.length | ||
| temp = Array.new(@store.length + 1) |
There was a problem hiding this comment.
Why make it one bigger? That gets pretty expensive in terms of time.
| def size | ||
| raise NotImplementedError, "Not yet implemented" | ||
| return abs(@back - @front + 1) |
| end | ||
|
|
||
|
|
||
| def to_s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation