-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angele Z. #41
base: master
Are you sure you want to change the base?
Angele Z. #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well you have most of the Stack class working, with one error, otherwise nice work. If you add any methods to Queue and want me to look over it, ping me in Slack and I'll give additional feedback.
I would have liked to see at least dequeue
attempted.
@@ -26,6 +40,13 @@ def empty? | |||
end | |||
|
|||
def to_s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
lib/stack.rb
Outdated
end | ||
|
||
def empty? | ||
raise NotImplementedError, "Not yet implemented" | ||
return @store ? true : false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be:
return @store ? true : false | |
return @store.empty? |
Because @store
is an instance of LinkedList and won't be nil
.
@@ -1,12 +1,26 @@ | |||
class Queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting dequeue and size are not implemented
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation