Cedar - Laurel S. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jul 24, 2022
|
|
||
| def possible_bipartition(dislikes): | ||
| """ Will return True or False if the given graph | ||
| can be bipartitioned without neighboring nodes put | ||
| into the same partition. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n * m) where n is the number of nodes/dogs |
There was a problem hiding this comment.
⏱ Time complexity will actually be O(n + m) because you traverse each node and each edge exactly once. O(n*m) would mean that you traverse all the edges in the entire graph for each node in the graph.
| Space Complexity: ? | ||
| Time Complexity: O(n * m) where n is the number of nodes/dogs | ||
| and m is the number of edges | ||
| Space Complexity: O(n) |
Comment on lines
+13
to
+21
| def createGraph(nodes): | ||
| graph = {} | ||
| for index, edge in enumerate(nodes): | ||
| graph[index] = [] | ||
| for neighbor in edge: | ||
| graph[index].append(neighbor) | ||
| return graph | ||
|
|
||
| graph = createGraph(dislikes) |
There was a problem hiding this comment.
Totally fine to do this, I just want to note that dislikes is already considered an adjacency list. Adjacency lists can be represented as either a list of lists where the nodes are represented by the indices and the edges are the values(which is what we provide), or as a dictionary where the nodes are the keys and the values are the edges.
Comment on lines
+31
to
+32
| if group == visited[dog]: | ||
| continue |
There was a problem hiding this comment.
Is there a way you might refactor your code to eliminate the continue statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.