-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maple - Monica C. #70
base: master
Are you sure you want to change the base?
Conversation
Grabbing this to grade! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
I left a comment about an unneeded import
statement as well as a correction to your time complexity calculation for the top-K problem, but otherwise this demonstrates sufficient mastery of the material and is good enough for a Green!
|
||
def top_k_frequent_elements(nums, k): | ||
""" This method will return the k most common elements | ||
In the case of a tie it will select the first occuring element. | ||
Time Complexity: ? | ||
Space Complexity: ? | ||
Time Complexity: O(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to account for the call to sorted
on line 49, which will take O(n * log(n)) time and thus dominate over the rest of the algorithm for the final time complexity.
@@ -1,19 +1,56 @@ | |||
|
|||
from http.client import CONTINUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this unneeded import
statement got pulled in by an overzealous IDE. It's usually worth removing unnecessary import
statements for the sake of maintaining clean code for style purposes.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions