Kate Lion C18 - Personal Site Project #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
😞 Some of the <div> elements should be replaced with <section> |
| All images include alternate text | ✅ |
| CSS | |
| Using class and ID names in style declarations | ✅ |
| Style declarations are DRY | Mostly |
| Using Flexbox and/or Grid | ✅ |
| Overall | 💯 |
| grid-template-columns: 20%, 60%, 20%; | ||
| } | ||
|
|
||
| .portfolio { |
There was a problem hiding this comment.
This class is only used inside one div element and copies a lot of the same properties that the div is given above. The code can be DRY-ed up by removing duplicates.
| a b o u t  m e | ||
| </p> | ||
| <p id="aboutme"> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Unde error adipisci maiores laudantium aliquam possimus perspiciatis, asperiores corporis ad debitis enim officiis saepe, pariatur veniam tempore ratione sapiente consequatur necessitatibus architecto rem quod. Laudantium, enim iste, possimus excepturi, blanditiis quas ullam quos incidunt tempora labore nemo. Obcaecati tempora fuga, esse illo, doloribus distinctio dolorem quisquam velit, sed quis asperiores nihil! Neque minus placeat sequi tenetur ipsum obcaecati facere accusamus officiis deleniti aliquam at aut in eos possimus similique quasi ullam, ea enim et unde non magni voluptatum nisi! Excepturi eligendi doloribus doloremque recusandae in totam reprehenderit inventore dignissimos eum aliquid quod, neque perferendis ad voluptatibus sed ipsam dolorum asperiores vel consectetur dolorem ducimus! Quod velit sit eveniet, animi eius consequuntur dolorem dignissimos aperiam perspiciatis ipsam nisi vel obcaecati minus! Itaque molestiae in doloremque, iste, rem temporibus atque voluptates laborum commodi, quibusdam impedit quod ipsa suscipit ratione? Dolorem, corporis tenetur tempora molestiae maxime temporibus eaque qui id impedit harum alias quae error unde voluptas assumenda possimus illum excepturi pariatur. Quaerat similique inventore sapiente nostrum aliquam, unde ea reprehenderit itaque doloremque ipsum explicabo, ab maiores consectetur a voluptate perspiciatis illo voluptatem recusandae alias natus? Dolorum, tempora? Eum dolorem tempora voluptas modi excepturi?</p> |
There was a problem hiding this comment.
It would be great if there was actual information about you on the page. =)
| @@ -5,8 +5,47 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <title>Document</title> | |||
There was a problem hiding this comment.
Make sure to change the title for each page. This is the text that appears in the tab in the browser.
| </a> | ||
| <a href="https://github.com/kate-varinda/viewing-party" class="titlelink">project: viewing-party</a> | ||
| <p class="projectdesc"> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Odio, architecto, soluta eius esse beatae assumenda fugit, sapiente molestias ut eos ratione! Distinctio ab amet tempora unde sed, consectetur illum illo! |
There was a problem hiding this comment.
It'd be great to see information about the different projects here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions